Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: styles.css is not declared in package.json #508

Merged
merged 3 commits into from
Nov 9, 2024

Conversation

molvqingtai
Copy link
Contributor

In some cases, using import 'sonner/dist/styles.css' to import may cause Vite build errors.

see: vitejs/vite#2657

Reproduce the demo:
https://github.com/molvqingtai/wxt-import-css-report

Copy link

vercel bot commented Nov 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sonner ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 3:42am

@sergey-shch
Copy link

@molvqingtai could u plz update your fix with the latest from base branch, so it can be finally merged 🙏

@molvqingtai
Copy link
Contributor Author

@sergey-shch updated

@sergey-shch
Copy link

Also requesting this @emilkowalski

@mlafeldt
Copy link

mlafeldt commented Nov 8, 2024

I ran into this as well and was about to submit a PR... Thanks, @molvqingtai!

@emilkowalski emilkowalski merged commit 55c42f8 into emilkowalski:main Nov 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants