ISSUE-369: Make vaul use data- attr for Content direction #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikita-liaukovich-epam is attempting to deploy a commit to the emil Team on Vercel. A member of the Team first needs to authorize it. |
|
This is great, thank you! Could we do that for all attributes? I can imagine people would want to style other ones as well. |
|
@emilkowalski done! I updated all custom |
|
Thank you so much @mikita-liaukovich-epam |
kodiakhq bot
referenced
this pull request
in technifit/tasker
Sep 13, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vaul](https://vaul.emilkowal.ski/) ([source](https://github.com/emilkowalski/vaul)) | [`0.9.2` -> `0.9.3`](https://renovatebot.com/diffs/npm/vaul/0.9.2/0.9.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>emilkowalski/vaul (vaul)</summary> ### [`v0.9.3`](https://github.com/emilkowalski/vaul/releases/tag/v0.9.3) [Compare Source](https://github.com/emilkowalski/vaul/compare/v0.9.2...v0.9.3) #### What's Changed Most importantly the scroll top issue should now be gone, issues with controlled state/defaultOpen prop should also be fixed. - feat: add export on props by [@​ferdylimmm9](https://github.com/ferdylimmm9) in [https://github.com/emilkowalski/vaul/pull/405](https://github.com/emilkowalski/vaul/pull/405) - adjust snapPoints on window resize by [@​bviebahn](https://github.com/bviebahn) in [https://github.com/emilkowalski/vaul/pull/399](https://github.com/emilkowalski/vaul/pull/399) - Export DialogProps type by [@​martynaskadisa](https://github.com/martynaskadisa) in [https://github.com/emilkowalski/vaul/pull/348](https://github.com/emilkowalski/vaul/pull/348) - fix: scroll top by [@​emilkowalski](https://github.com/emilkowalski) in [https://github.com/emilkowalski/vaul/pull/406](https://github.com/emilkowalski/vaul/pull/406) - ISSUE-369: Make vaul use data- attr for Content direction by [@​mikita-liaukovich-epam](https://github.com/mikita-liaukovich-epam) in [https://github.com/emilkowalski/vaul/pull/404](https://github.com/emilkowalski/vaul/pull/404) - fix: controlled state by [@​emilkowalski](https://github.com/emilkowalski) in [https://github.com/emilkowalski/vaul/pull/408](https://github.com/emilkowalski/vaul/pull/408) - refactor: background scaling by [@​emilkowalski](https://github.com/emilkowalski) in [https://github.com/emilkowalski/vaul/pull/409](https://github.com/emilkowalski/vaul/pull/409) - feat: add prop to disable input repositioning by [@​emilkowalski](https://github.com/emilkowalski) in [https://github.com/emilkowalski/vaul/pull/410](https://github.com/emilkowalski/vaul/pull/410) #### New Contributors - [@​ferdylimmm9](https://github.com/ferdylimmm9) made their first contribution in [https://github.com/emilkowalski/vaul/pull/405](https://github.com/emilkowalski/vaul/pull/405) - [@​bviebahn](https://github.com/bviebahn) made their first contribution in [https://github.com/emilkowalski/vaul/pull/399](https://github.com/emilkowalski/vaul/pull/399) - [@​martynaskadisa](https://github.com/martynaskadisa) made their first contribution in [https://github.com/emilkowalski/vaul/pull/348](https://github.com/emilkowalski/vaul/pull/348) - [@​mikita-liaukovich-epam](https://github.com/mikita-liaukovich-epam) made their first contribution in [https://github.com/emilkowalski/vaul/pull/404](https://github.com/emilkowalski/vaul/pull/404) **Full Changelog**: emilkowalski/vaul@v0.9.2...v0.9.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/technifit/tasker).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: 369
vaultis fixed instyle.css