Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Ensure drawer opens at the specified active snap point on initial render #473

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix: Ensure drawer opens at the specified active snap point on initial render #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f8a3fcd
add activeSnapPointIndex to context type
KhalafAbdi Oct 2, 2024
0738ad3
passing activeSnapPointIndex to context
KhalafAbdi Oct 2, 2024
d7f6650
getting and using activeSnapPointIndex from context
KhalafAbdi Oct 2, 2024
cc0f671
Added back spaces
KhalafAbdi Oct 2, 2024
0637a23
added back space
KhalafAbdi Oct 2, 2024
3ae39a0
activeSnapPointIndex fallback
KhalafAbdi Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ interface DrawerContextValue {
keyboardIsOpen: React.MutableRefObject<boolean>;
snapPointsOffset: number[] | null;
snapPoints?: (number | string)[] | null;
activeSnapPointIndex?: number;
modal: boolean;
shouldFade: boolean;
activeSnapPoint?: number | string | null;
Expand Down
4 changes: 3 additions & 1 deletion src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,6 +765,7 @@ export function Root({
keyboardIsOpen,
modal,
snapPointsOffset,
activeSnapPointIndex,
direction,
shouldScaleBackground,
setBackgroundColorOnScale,
Expand Down Expand Up @@ -818,6 +819,7 @@ export const Content = React.forwardRef<HTMLDivElement, ContentProps>(function (
onDrag,
keyboardIsOpen,
snapPointsOffset,
activeSnapPointIndex,
modal,
isOpen,
direction,
Expand Down Expand Up @@ -885,7 +887,7 @@ export const Content = React.forwardRef<HTMLDivElement, ContentProps>(function (
style={
snapPointsOffset && snapPointsOffset.length > 0
? ({
'--snap-point-height': `${snapPointsOffset[0]!}px`,
'--snap-point-height': `${snapPointsOffset[activeSnapPointIndex ?? 0]!}px`,
...style,
} as React.CSSProperties)
: style
Expand Down
Loading