-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #366 #512
base: 1.20
Are you sure you want to change the base?
fix #366 #512
Conversation
You'll need to fix the import situation for this to be merged and reviewed correctly. |
What's the correct import order? I can make my IDE sort them according to the order. |
Whatever order they started in, I don't have a formal definition |
Is this OK? |
This still seems to include star imports, and in style remarks seems to reformat a lot of files to be inconsistent with the rest of the codebase. You should not run your autoformatter on this |
Can you receive the notification of my commits, or of only comments? |
This looks relatively reasonable (though I don't know why I didn't mention that I don't use jetbrain contracts in my codebase), but I'd like to take a proper look at it after the noise of 1.20.5 has settled down. Thanks for sticking with me. |
Any progress here? |
Not backward compatible.
(My IDE seemed to re-arrange the imports.)