Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate item groups in correct order #813

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

embeddedt
Copy link
Contributor

Since vanilla's search ItemGroup pulls data from the other item groups, we have to be careful to update the groups' entries in the correct order, otherwise the search group will persist outdated stacks from the previous reload. This change fixes #774.

Copy link
Owner

@emilyploszaj emilyploszaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very peculiar design choice, thanks for figuring this out.

xplat/src/main/java/dev/emi/emi/registry/EmiStackList.java Outdated Show resolved Hide resolved
@emilyploszaj emilyploszaj merged commit 9b99ce7 into emilyploszaj:1.21 Dec 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EMI appears to not be resetting cache on leaving worlds, which causes problems on relog
2 participants