Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kube client libraries 1.20.2→1.20.4 #4066

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

LukeShu
Copy link
Contributor

@LukeShu LukeShu commented Jan 31, 2022

Description

This should make merging Douglas' Argo PR simpler. It seems that there
was actually no change in the client libraries between Kube 1.20.2 and
Kube 1.20.4, so that makes this whole thing a little silly, but it is what
it is; I do expect it to make the merge/rebase easier.

Related Issues

Testing

None.

Checklist

  • I made sure to update CHANGELOG.md. - no applicable changes

    Remember, the CHANGELOG needs to mention:

    • Any new features
    • Any changes to our included version of Envoy
    • Any non-backward-compatible changes
    • Any deprecations
  • This is unlikely to impact how Ambassador performs at scale. - turns out to be a no-op change

    Remember, things that might have an impact at scale include:

    • Any significant changes in memory use that might require adjusting the memory limits
    • Any significant changes in CPU use that might require adjusting the CPU limits
    • Anything that might change how many replicas users should use
    • Changes that impact data-plane latency/scalability
  • My change is adequately tested. - turns out to be a no-op change

    Remember when considering testing:

    • Your change needs to be specifically covered by tests.
      • Tests need to cover all the states where your change is relevant: for example, if you add a behavior that can be enabled or disabled, you'll need tests that cover the enabled case and tests that cover the disabled case. It's not sufficient just to test with the behavior enabled.
    • You also need to make sure that the entire area being changed has adequate test coverage.
      • If existing tests don't actually cover the entire area being changed, add tests.
      • This applies even for aspects of the area that you're not changing – check the test coverage, and improve it if needed!
    • We should lean on the bulk of code being covered by unit tests, but...
    • ... an end-to-end test should cover the integration points
  • I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently. - no tricks

This should make merging Douglas' Argo PR simpler.  It seems that there
was actually no change in the client libraries between Kube 1.20.2 and
Kube 1.20.4, so that makes this whole thing a little silly, but it is what
it is; I do expect it to make the merge/rebase easier.

Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. That's... a lotta lines changed. 🙂 Hit it!!

@LukeShu LukeShu merged commit 4921449 into master Feb 1, 2022
@LukeShu LukeShu deleted the lukeshu/upgrade-client-go branch February 1, 2022 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants