Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(python): updates multiple dependencies for python #5338

Merged
merged 6 commits into from
Oct 9, 2023

Conversation

LanceEa
Copy link
Contributor

@LanceEa LanceEa commented Oct 9, 2023

Description

Note: this is setting on top of: #5337 and #5336

This updates a bunch of python deps and docker deps to resolve multiple open dependabot.

I also had issues with distutils (see commit messages for details) so the current imports in scripts were replaced since it is deprecated and recommended by the python project to move away from it. Note: I believe some of the scripts in releng/lib are no longer used so follow-up cleanup work should be done at some point.

Bumped test Docker base images to ubuntu 23.10 and also switched the test-stats to be consistent with the others as well. Normalized each of the

Related Issues

Testing

Cleanly ran make generate and built containers. CI is green.

Checklist

  • Does my change need to be backported to a previous release?
  • I made sure to update CHANGELOG.md.
  • This is unlikely to impact how Ambassador performs at scale.
  • My change is adequately tested.
  • I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.
  • The changes in this PR have been reviewed for security concerns and adherence to security best practices.

@LanceEa LanceEa changed the base branch from master to laustin/bump-consul October 9, 2023 03:07
@LanceEa LanceEa force-pushed the laustin/bump-python-deps branch 2 times, most recently from dbd13ba to f6ccb5a Compare October 9, 2023 03:46
@LanceEa LanceEa marked this pull request as ready for review October 9, 2023 04:25
rick-a-lane-ii
rick-a-lane-ii previously approved these changes Oct 9, 2023
tenshinhigashi
tenshinhigashi previously approved these changes Oct 9, 2023
Lance Austin added 6 commits October 9, 2023 10:27
Updating to latest tools before updating other python deps.

Signed-off-by: Lance Austin <laustin@datawire.io>
Ran `cd python && pip-compile --upgrade --allow-unsafe -q requirements.in`
which bumped all the deps in `python` folder.

Some notable ones:
- setuptools
- click
- charset-normalizer
- flask
- werkzeug
- typing-extensions
- gunicorn

Removed direct import of deprecated disutils because it was cause
it was causing conflicts with the latest `setuptools`.

Also, due to similiar issue as outlined here:
pypa/pip#5247

I had to ignore uninstalling older version of packaging to allow
pip to install the newer versions in base-pip container.

Signed-off-by: Lance Austin <laustin@datawire.io>
Resolves open dependabot PRs and updates to
latest Flask release.

Normalizes project to use pyproject.toml with pip-compile
for creating requirements.txt.

Signed-off-by: Lance Austin <laustin@datawire.io>
Resolves open dependabot PRs and updates to
latest Flask release.

Normalizes project to use pyproject.toml with pip-compile
for creating requirements.txt.

Signed-off-by: Lance Austin <laustin@datawire.io>
Resolves open dependabot PRs and updates to
latest Flask release.

Normalizes project to use pyproject.toml with pip-compile
for creating requirements.txt.

Signed-off-by: Lance Austin <laustin@datawire.io>
Signed-off-by: Lance Austin <laustin@datawire.io>
Base automatically changed from laustin/bump-consul to master October 9, 2023 16:00
@LanceEa LanceEa dismissed stale reviews from tenshinhigashi and rick-a-lane-ii October 9, 2023 16:00

The base branch was changed.

@LanceEa
Copy link
Contributor Author

LanceEa commented Oct 9, 2023

apparently, merge commits still cause stacked PR's to mark reviews as stale as well. 🤷‍♂️

@LanceEa LanceEa merged commit 9fe6be4 into master Oct 9, 2023
36 checks passed
@LanceEa LanceEa deleted the laustin/bump-python-deps branch October 9, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants