Enable TLS support by default #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently considered a best practice to employ HTTPS for all HTTP exchanges, and this becomes particularly crucial when handling sensitive secrets. Sadly, the default feature flags of this crate may not facilitate the seamless use of HTTPS if newer dependencies are used (c.f. #5): TLS support is not explicitly enabled by default, resulting in
httpsURLs being unsupported with a rather cryptic error message.To improve the ergonomics of this crate in common scenarios, let's explicitly enable TLS support by default. Users with specific requirements can still choose to opt out of this support by explicitly disabling the default features of this crate in their
Cargo.tomlfile.