Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpuio: Use new feature flag for const functions #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hanmertens
Copy link

@hanmertens hanmertens commented May 8, 2021

This is necessary since rust-lang/rust#84310, otherwise new nightlies can't build cpuio.

Unfortunately, merging this means older nightlies can no longer compile the crate since new feature flags yield errors on nightlies that don't recognize it yet.

Fixes #8.

This is necessary since rust-lang/rust#84310, otherwise new nightlies
can't build cpuio.

Fixes emk#8.
@apogeeoak
Copy link

I ran into this issue as well. I think releasing this as a new version (0.4.0) and possibly mentioning it in the readme would provide sufficient notice of the breaking change.

phil-opp added a commit to rust-osdev/pic8259 that referenced this pull request May 17, 2021
@phil-opp
Copy link
Contributor

Since this project appears to be abandoned, I created a fork of the pic8259 crate under the rust-osdev organization: https://github.com/rust-osdev/pic8259. The forked crate is avaliable on crates.io as pic8259 v0.10.1. This PR is already included, so thanks for creating it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency causes Nightly compile error
3 participants