Pull request review radiantearth#2

emmanuelmathot · Sep 9, 2020 · c89bc18 · c89bc18
1 parent ee62664
commit c89bc18
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 24 deletions.
diff --git a/extensions/sat/README.md b/extensions/sat/README.md
@@ -23,8 +23,6 @@ The Satellite extension requires the [Instrument Fields](../../item-spec/common-
 | sat:absolute_orbit     | integer       | The obsolute orbit number at the time of acquisition. |
 | sat:relative_orbit     | integer       | The relative orbit number at the time of acquisition. |
 | sat:anx_date_time     | date_time    | The Ascending Node Crossing (ANX) UTC time |
-| sat:along_track_incidence_angle | number | The along track incidence angle |
-| sat:across_track_incidence_angle | number | The across track incidence angle |
 
 *At least one of the fields must be specified.*
 
@@ -38,10 +36,6 @@ The Satellite extension requires the [Instrument Fields](../../item-spec/common-
 
 **sat:anx_date_time** is the UTC time when the satellite crosses the [Ascending Node](https://en.wikipedia.org/wiki/Orbital_node). For geocentric and heliocentric orbits, the ascending node (or north node) is where the orbiting object moves north through the plane of reference.
 
-**sat:along_track_incidence_angle** is the angle (in degrees) between the vertical position of the satellite and its forward or backward viewing direction. If viewed from the ground point corresponding to the scene center, the along track incidence angle has a positive value if the viewing direction is northward.
-
-**sat:across_track_incidence_angle** is the angle (in degrees) between the vertical position of the satellite and its side-viewing direction when the sensor is scanning along the side. If viewed from the ground point corresponding to the scene center, the across track incidence angle has a positive value if the viewing direction is eastward.
-
 ## Implementations
 
 [DotNetStac](https://github.com/Terradue/DotNetStac) uses this extension specification for the satellite extension plugin with accessor to the value specified of this extension and allowing orbital computation from orbital state vectors.

diff --git a/extensions/sat/json-schema/schema.json b/extensions/sat/json-schema/schema.json
@@ -33,17 +33,9 @@
         },
         "properties": {
           "type": "object",
-          "anyOf": [
-            {"required": ["sat:platform_serial_identifier"]},
-            {"required": ["sat:orbit_state"]},
-            {"required": ["sat:absolute_orbit"]},
-            {"required": ["sat:relative_orbit"]},
-            {"required": ["sat:anx_date_time"]},
-            {"required": ["sat:along_track_incidence_angle"]},
-            {"required": ["sat:across_track_incidence_angle"]}
-          ],
+          "minProperties": 1,
           "properties": {
-            "sat:platform_serial_identifier": {
+            "sat:platform_international_designator": {
               "type": "string",
               "minimum": 1
             },
@@ -67,14 +59,6 @@
             "sat:anx_date_time": {
               "type": "string",
               "format": "date-time"
-            },
-            "sat:along_track_incidence_angle": {
-              "type": "number",
-              "minimum": 1
-            },
-            "sat:across_track_incidence_angle": {
-              "type": "number",
-              "minimum": 1
             }
           }
         }