forked from OpenSourceEBike/TSDZ2-Smart-EBike
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bleeding edge Unit Testing #109
Open
dzid26
wants to merge
7
commits into
emmebrusa:master
Choose a base branch
from
dzid26:Unit_testing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small c-files cleanup to help with compilation. Displays test results in Github Actions summary and PRs
Added pytest --force
Fixed [-Wparentheses] parentheses around ‘-’ inside ‘<<’ BATTERY_VOLTAGE_SHUTDOWN_10_BIT Fixed [-Wdiscarded-qualifiers] return discards ‘volatile’ qualifier from pointer target type &m_configuration_variables; Fixed [-Wsign-compare] comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ Fixed [-Wunused-but-set-variable] enable walk assist debounce code path by default Fixed [-Wunused-label] Fixed warning C4244: '=': conversion from 'int16_t' to 'uint8_t', possible loss of data
@emmebrusa any concerns ? |
I didn't go into detail about what this means for the user, when I saw "File changed 30" and "File changed 20" I stopped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python bindings to the c code - pytest testing
https://youtu.be/zW_HyDTPjO0?t=161
allows testing static functions
allows using advanced testing libraries, such as hypothesis or numpy
function mocking
Extra warnings from gcc
tests coverage of the c-code
easy to use, automatic IDE's integrations
provides easy testcase debugging, (but hard c-code debugging)
What's included:
.cdef
definition creation !) and module compilationpip install .
)pytest
)Minor code fixes:
(details in the commit message df8b31d)
struct_configuration_variables
casting<<
ordering inBATTERY_VOLTAGE_SHUTDOWN_10_BIT
- (I made sure this doesn't change calculated value)