Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warning for missing void in function prototypes (#72) #75

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

chgpalmer
Copy link

Building firmware no longer outputs warnings as per #72

sdcc: Calling assembler...
sdcc: sdasstm8 -plosgffwy "../../bin/timers.asm"
sdcc --verbose -c -I../common/STM8S_StdPeriph_Lib/inc -I../common -mstm8 -DSTM8S105 -Ddouble=float --std-c99 --nolospre --opt-code-speed --peep-asm --peep-file peep.txt --out-fmt-ihx --debug  -o../../bin/ ebike_app.c
sdcc: Calling preprocessor...
sdcc: sdcpp -nostdinc -Wall -std=c99 -I../common/STM8S_StdPeriph_Lib/inc -I../common -DSTM8S105 -Ddouble=float --obj-ext=.rel -D__SDCC_STACK_AUTO -D__SDCC_CHAR_UNSIGNED -D__SDCC_MODEL_MEDIUM -D__SDCC_OPTIMIZE_SPEED -D__SDCC_INT_LONG_REENT -D__SDCC_FLOAT_REENT -D__SDCCCALL=1 -D__SDCC=4_3_0 -D__SDCC_VERSION_MAJOR=4 -D__SDCC_VERSION_MINOR=3 -D__SDCC_VERSION_PATCH=0 -D__SDCC_REVISION=14184 -D__SDCC_stm8 -D__STDC_NO_COMPLEX__=1 -D__STDC_NO_THREADS__=1 -D__STDC_NO_ATOMICS__=1 -D__STDC_NO_VLA__=1 -D__STDC_ISO_10646__=201409L -D__SIZEOF_FLOAT__=4 -D__SIZEOF_DOUBLE__=4 -D__SDCC_BITINT_MAXWIDTH=64 -isystem /opt/homebrew/bin/../share/sdcc/include/stm8 -isystem /opt/homebrew/Cellar/sdcc/4.3.0/share/sdcc/include/stm8 -isystem /opt/homebrew/bin/../share/sdcc/include -isystem /opt/homebrew/Cellar/sdcc/4.3.0/share/sdcc/include  -xc ebike_app.c 
sdcc: Generating code...
sdcc: Calling assembler...
sdcc: sdasstm8 -plosgffwy "../../bin/ebike_app.asm"

@dzid26
Copy link

dzid26 commented Aug 25, 2023

Maybe you could bump sdcc version in the CI to the latest that causes the warnings?

I don't know if there is a way to always point to the latest...

@chgpalmer
Copy link
Author

Added commit that bumps SDCC version to 4.3.0, which is both the most recent release and what I am using via mac homebrew

@chgpalmer
Copy link
Author

The github build workflow fails using 4.3.0 on Windows so I've removed the version update commit
Build now passes again: https://github.com/chgpalmer/TSDZ2-Smart-EBike-1/actions/runs/5979860875

Which compiler we use doesn't affect the validity of this patch. A new issue could be raised to increment the SDCC version

@dzid26
Copy link

dzid26 commented Aug 25, 2023

https://github.com/chgpalmer/TSDZ2-Smart-EBike-1/actions/runs/5979789568
Interesting. I actually had some issues when I updated to 4.3.0 on Windows. It seemed like CC1 was used instead of SDCC, but I am not sure.

I don't think I am going to investigate this, but I created a vague issue for this #76

@emmebrusa emmebrusa merged commit 93f874b into emmebrusa:master Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants