Fix: don't consider input files as moved when write failed (#1156)

emmercm · Jun 11, 2024 · 52bfae1 · 52bfae1
1 parent ed1f267
commit 52bfae1
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/src/modules/candidateWriter.ts b/src/modules/candidateWriter.ts
@@ -203,8 +203,9 @@ export default class CandidateWriter extends Module {
       }
     }
 
+    let written = false;
     for (let i = 0; i <= this.options.getWriteRetry(); i += 1) {
-      const written = await this.writeZipFile(
+      written = await this.writeZipFile(
         dat,
         releaseCandidate,
         outputZip,
@@ -235,6 +236,9 @@ export default class CandidateWriter extends Module {
         }
       }
     }
+    if (!written) {
+      return;
+    }
 
     inputToOutputZipEntries.forEach(([inputRomFile]) => this.enqueueFileDeletion(inputRomFile));
   }
@@ -439,8 +443,9 @@ export default class CandidateWriter extends Module {
       }
     }
 
+    let written = false;
     for (let i = 0; i <= this.options.getWriteRetry(); i += 1) {
-      const written = await this.writeRawFile(dat, releaseCandidate, inputRomFile, outputFilePath);
+      written = await this.writeRawFile(dat, releaseCandidate, inputRomFile, outputFilePath);
 
       if (written && !this.options.shouldTest()) {
         // Successfully written, unknown if valid
@@ -466,6 +471,10 @@ export default class CandidateWriter extends Module {
         }
       }
     }
+    if (!written) {
+      return;
+    }
+
     this.enqueueFileDeletion(inputRomFile);
   }