Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: CHD support #1006

Merged
merged 94 commits into from
Jul 26, 2024
Merged

Feature: CHD support #1006

merged 94 commits into from
Jul 26, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Mar 18, 2024

RE: #937

@emmercm emmercm self-assigned this Mar 18, 2024
Base automatically changed from emmercm/file-factory-cache to main March 21, 2024 03:11
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 79.62963% with 44 lines in your changes missing coverage. Please review.

Project coverage is 92.70%. Comparing base (a50a78c) to head (8bed768).

Files Patch % Lines
src/types/files/archives/chd/chd.ts 70.66% 22 Missing ⚠️
src/types/files/archives/chd/chdBinCueParser.ts 75.92% 13 Missing ⚠️
src/types/files/archives/chd/chdGdiParser.ts 77.41% 7 Missing ⚠️
src/modules/candidateExtensionCorrector.ts 92.30% 1 Missing ⚠️
src/types/files/archives/zip.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           emmercm/3.0.0-feature    #1006      +/-   ##
=========================================================
- Coverage                  93.35%   92.70%   -0.65%     
=========================================================
  Files                        109      112       +3     
  Lines                       6722     6922     +200     
  Branches                    1477     1638     +161     
=========================================================
+ Hits                        6275     6417     +142     
- Misses                       446      504      +58     
  Partials                       1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm marked this pull request as ready for review July 26, 2024 01:38
@emmercm emmercm merged commit a740ef1 into emmercm/3.0.0-feature Jul 26, 2024
17 of 20 checks passed
@emmercm emmercm deleted the emmercm/chd branch July 26, 2024 01:38
Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/3.0.0-feature" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant