Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support MAME software list DATs #1031

Merged
merged 5 commits into from
May 9, 2024
Merged

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Mar 22, 2024

No description provided.

@emmercm emmercm self-assigned this Mar 22, 2024
Copy link

github-actions bot commented Mar 22, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/mame-software-lists" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm marked this pull request as ready for review May 9, 2024 00:33
@emmercm emmercm enabled auto-merge (squash) May 9, 2024 00:34
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 84.44444% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 93.09%. Comparing base (aef5adb) to head (015757c).

Files Patch % Lines
src/modules/datScanner.ts 61.53% 5 Missing ⚠️
src/types/dats/softwarelist/softwareListDat.ts 83.33% 3 Missing ⚠️
src/types/dats/softwarelist/software.ts 87.50% 2 Missing ⚠️
src/types/dats/softwarelist/softwareListsDat.ts 88.88% 2 Missing ⚠️
src/types/dats/softwarelist/dataArea.ts 90.90% 1 Missing ⚠️
src/types/dats/softwarelist/part.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1031      +/-   ##
==========================================
- Coverage   93.14%   93.09%   -0.06%     
==========================================
  Files          92       97       +5     
  Lines        6129     6211      +82     
  Branches     1375     1387      +12     
==========================================
+ Hits         5709     5782      +73     
- Misses        419      428       +9     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 7f59ca6 into main May 9, 2024
54 of 55 checks passed
@emmercm emmercm deleted the emmercm/mame-software-lists branch May 9, 2024 00:40
Copy link

github-actions bot commented Jun 8, 2024

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant