Refactor: ES-DE Name Wrong #1061
Open
+127
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Branch testing instructionsThis pull request can be tested locally with the following command: npm exec --yes -- "github:maxexcloo/igir#patch-1" [commands..] [options]Comment generated by the Pull Request Commenter workflow. |
|
@maxexcloo do the two have different folder structures? Admittedly, I've never used any version of EmulationStation. I couldn't find reliable information about how the two might diverge. |
|
EmulationStation hasn’t been updated since 2015 so I’d say ES-DE would be a more accurate name - I think folder structures may differ very slightly (will check when I’m back at my desk). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for this one, I realize you pointed this out before. It turns out that ES-DE is not EmulationStation, I think it would make sense to rename EmulationStation to ES-DE in the code to make this accurate.