Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Bun: use FileHandle.writeFile() #1114

Merged
merged 2 commits into from
May 9, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented May 7, 2024

@emmercm emmercm self-assigned this May 7, 2024
Copy link

github-actions bot commented May 7, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/bun-writefile-refactor" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm marked this pull request as ready for review May 9, 2024 00:35
@emmercm emmercm enabled auto-merge (squash) May 9, 2024 00:35
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.09%. Comparing base (7f59ca6) to head (12d2d51).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1114   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files          97       97           
  Lines        6211     6211           
  Branches     1479     1387   -92     
=======================================
  Hits         5782     5782           
- Misses        408      428   +20     
+ Partials       21        1   -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit c32113f into main May 9, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/bun-writefile-refactor branch May 9, 2024 00:47
Copy link

github-actions bot commented Jun 8, 2024

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant