Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: allow reporting with no input when not writing ROMs #1118

Merged
merged 3 commits into from
May 8, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented May 8, 2024

Fixes: #1111

@emmercm emmercm self-assigned this May 8, 2024
@emmercm emmercm enabled auto-merge (squash) May 8, 2024 03:59
Copy link

github-actions bot commented May 8, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/report-without-input-roms" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.13%. Comparing base (4ee0d8c) to head (e37ab94).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1118   +/-   ##
=======================================
  Coverage   93.12%   93.13%           
=======================================
  Files          92       92           
  Lines        6109     6116    +7     
  Branches     1461     1373   -88     
=======================================
+ Hits         5689     5696    +7     
- Misses        399      419   +20     
+ Partials       21        1   -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 57d166d into main May 8, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/report-without-input-roms branch May 8, 2024 04:19
Copy link

github-actions bot commented Jun 8, 2024

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make igir report work without roms
1 participant