Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: correct invalid extensions when raw-copying archives #1128

Merged
merged 6 commits into from
May 10, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented May 10, 2024

No description provided.

@emmercm emmercm self-assigned this May 10, 2024
@emmercm emmercm enabled auto-merge (squash) May 10, 2024 16:16
Copy link

github-actions bot commented May 10, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/fix-archive-extension" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 83.96226% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 93.25%. Comparing base (7adcf96) to head (2b5e04f).

Files Patch % Lines
src/types/files/fileFactory.ts 83.33% 5 Missing ⚠️
src/types/files/archives/z.ts 50.00% 4 Missing ⚠️
src/types/files/archives/zipSpanned.ts 50.00% 4 Missing ⚠️
src/types/files/archives/zipX.ts 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
- Coverage   93.46%   93.25%   -0.21%     
==========================================
  Files          97      102       +5     
  Lines        6289     6347      +58     
  Branches     1406     1510     +104     
==========================================
+ Hits         5878     5919      +41     
+ Misses        410      406       -4     
- Partials        1       22      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 9832172 into main May 10, 2024
53 of 54 checks passed
@emmercm emmercm deleted the emmercm/fix-archive-extension branch May 10, 2024 22:17
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant