Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove the "game" suffix from {gameRegion} and {gameLanguage} #1166

Merged
merged 3 commits into from
Jun 16, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jun 16, 2024

No description provided.

@emmercm emmercm self-assigned this Jun 16, 2024
@emmercm emmercm enabled auto-merge (squash) June 16, 2024 22:39
@emmercm emmercm disabled auto-merge June 16, 2024 22:43
Copy link

github-actions bot commented Jun 16, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/shorten-game-tokens" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm enabled auto-merge (squash) June 16, 2024 22:46
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.09%. Comparing base (3b715d6) to head (23a0011).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
- Coverage   93.09%   93.09%   -0.01%     
==========================================
  Files         103      103              
  Lines        6429     6427       -2     
  Branches     1520     1520              
==========================================
- Hits         5985     5983       -2     
  Misses        421      421              
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit f2b546c into main Jun 16, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/shorten-game-tokens branch June 16, 2024 22:58
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant