Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: allow exact-matching of archives in DATs #1175

Merged
merged 6 commits into from
Jun 30, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jun 22, 2024

Fixes: #1170

@emmercm emmercm self-assigned this Jun 22, 2024
Copy link

github-actions bot commented Jun 22, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/allow-archive-exact-matches" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm marked this pull request as ready for review June 23, 2024 04:54
@emmercm emmercm enabled auto-merge (squash) June 30, 2024 01:30
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.14%. Comparing base (9245a31) to head (63314f2).

Files Patch % Lines
src/igir.ts 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1175      +/-   ##
==========================================
+ Coverage   93.13%   93.14%   +0.01%     
==========================================
  Files         105      105              
  Lines        6436     6481      +45     
  Branches     1526     1529       +3     
==========================================
+ Hits         5994     6037      +43     
- Misses        419      421       +2     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 2b3111f into main Jun 30, 2024
53 of 54 checks passed
@emmercm emmercm deleted the emmercm/allow-archive-exact-matches branch June 30, 2024 01:36
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archives listed in DATs never match
1 participant