Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: turn on the 'allowUnreachableCode' TypeScript option #1194

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jun 30, 2024

No description provided.

@emmercm emmercm self-assigned this Jun 30, 2024
@emmercm emmercm enabled auto-merge (squash) June 30, 2024 02:20
Copy link

github-actions bot commented Jun 30, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/tsconfig-allowUnreachableCode" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (e50eee0) to head (56d9f4f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1194      +/-   ##
==========================================
+ Coverage   92.90%   93.15%   +0.24%     
==========================================
  Files         105      105              
  Lines        6484     6484              
  Branches     1430     1530     +100     
==========================================
+ Hits         6024     6040      +16     
+ Misses        459      421      -38     
- Partials        1       23      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 81c98e8 into main Jul 3, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/tsconfig-allowUnreachableCode branch July 3, 2024 20:16
Copy link

github-actions bot commented Aug 3, 2024

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant