Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: libretro System.dat BIOS assumption #1207

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 11, 2024

Fixes: #1204

@emmercm emmercm self-assigned this Jul 11, 2024
@emmercm emmercm enabled auto-merge (squash) July 11, 2024 14:17
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.10%. Comparing base (c555d9a) to head (e363703).

Files Patch % Lines
src/modules/datScanner.ts 44.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1207      +/-   ##
==========================================
- Coverage   93.15%   93.10%   -0.06%     
==========================================
  Files         105      105              
  Lines        6490     6497       +7     
  Branches     1535     1540       +5     
==========================================
+ Hits         6046     6049       +3     
- Misses        421      425       +4     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 7c300db into main Jul 11, 2024
54 of 55 checks passed
@emmercm emmercm deleted the emmercm/fix-libretro-bios branch July 11, 2024 14:23
Copy link

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/fix-libretro-bios" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@steveonjava
Copy link

Fix looks great. Thanks for taking care of this so quickly, Christian. 🙏

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dat with 1 game and many roms treats each rom as a separate game
2 participants