Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: dir2dat use Game and ROM information from candidates #1213

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 12, 2024

RE: #1174

@emmercm emmercm self-assigned this Jul 12, 2024
@emmercm emmercm enabled auto-merge (squash) July 12, 2024 16:20
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.10%. Comparing base (895ce43) to head (e722db2).

Files Patch % Lines
src/types/dats/rom.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
+ Coverage   92.85%   93.10%   +0.24%     
==========================================
  Files         105      105              
  Lines        6498     6513      +15     
  Branches     1540     1435     -105     
==========================================
+ Hits         6034     6064      +30     
- Misses        440      448       +8     
+ Partials       24        1      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 865955a into main Jul 12, 2024
54 of 55 checks passed
@emmercm emmercm deleted the emmercm/dir2dat-candidates branch July 12, 2024 16:50
Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#main" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant