Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't throw if a single dat/input/patch directory is empty #1231

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 22, 2024

Fixes: #1199

@emmercm emmercm self-assigned this Jul 22, 2024
@emmercm emmercm enabled auto-merge (squash) July 22, 2024 04:37
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.22%. Comparing base (afb6449) to head (002197f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1231      +/-   ##
==========================================
+ Coverage   93.17%   93.22%   +0.05%     
==========================================
  Files         108      108              
  Lines        6711     6706       -5     
  Branches     1480     1584     +104     
==========================================
- Hits         6253     6252       -1     
+ Misses        457      430      -27     
- Partials        1       24      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 216994d into main Jul 22, 2024
56 checks passed
@emmercm emmercm deleted the emmercm/allow-some-empty-dirs branch July 22, 2024 04:43
Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#main" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when a input folder is empty
1 participant