Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: cache file signature detection #1238

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 26, 2024

Fixes: #1234

@emmercm emmercm self-assigned this Jul 26, 2024
@emmercm emmercm enabled auto-merge (squash) July 26, 2024 01:08
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.22%. Comparing base (5d27f2b) to head (b07a141).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1238      +/-   ##
==========================================
+ Coverage   92.96%   93.22%   +0.26%     
==========================================
  Files         108      108              
  Lines        6723     6745      +22     
  Branches     1592     1483     -109     
==========================================
+ Hits         6250     6288      +38     
- Misses        448      456       +8     
+ Partials       25        1      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 54d4b73 into main Jul 26, 2024
54 of 55 checks passed
@emmercm emmercm deleted the emmercm/cache-signatures branch July 26, 2024 01:12
Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#main" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

@dch82
Copy link

dch82 commented Jul 26, 2024

Nice @emmercm! I can see this speeding up the process, but I will build a nightly and test it out.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache more stuff
2 participants