Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: don't calculate CRCs for raw files when not testing #567

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Aug 10, 2023

Fixes #441

@emmercm emmercm self-assigned this Aug 10, 2023
@emmercm emmercm enabled auto-merge (squash) August 10, 2023 18:37
@github-actions
Copy link

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/raw-file-crc-efficiency" [commands..] [options]

@codecov-commenter
Copy link

Codecov Report

Merging #567 (085d160) into main (fb7d92a) will decrease coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   93.57%   93.29%   -0.29%     
==========================================
  Files          76       76              
  Lines        4545     4547       +2     
  Branches      967      968       +1     
==========================================
- Hits         4253     4242      -11     
- Misses        278      290      +12     
- Partials       14       15       +1     
Files Changed Coverage Δ
src/modules/candidateGenerator.ts 97.22% <100.00%> (+1.38%) ⬆️
src/types/files/archives/archive.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@emmercm emmercm merged commit 6d4e249 into main Aug 10, 2023
38 checks passed
@emmercm emmercm deleted the emmercm/raw-file-crc-efficiency branch August 10, 2023 18:53
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't calculate checksums when there are no DATs and the output isn't being tested
2 participants