Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Array[0] is not guaranteed to be defined #680

Merged
merged 5 commits into from
Sep 22, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Sep 22, 2023

No description provided.

@emmercm emmercm self-assigned this Sep 22, 2023
@emmercm emmercm enabled auto-merge (squash) September 22, 2023 01:47
@github-actions
Copy link

github-actions bot commented Sep 22, 2023

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/dat-merge-split-no-parent-fix" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #680 (1a88cba) into main (d141497) will decrease coverage by 0.33%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
- Coverage   93.48%   93.16%   -0.33%     
==========================================
  Files          82       82              
  Lines        4851     4855       +4     
  Branches     1055     1058       +3     
==========================================
- Hits         4535     4523      -12     
- Misses        299      314      +15     
- Partials       17       18       +1     
Files Changed Coverage Δ
src/modules/datMergerSplitter.ts 93.84% <87.50%> (-1.24%) ⬇️
src/types/dats/game.ts 97.45% <100.00%> (ø)
src/types/files/archives/zip.ts 96.87% <100.00%> (ø)
src/types/gameConsole.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@emmercm emmercm merged commit 551436a into main Sep 22, 2023
51 of 52 checks passed
@emmercm emmercm deleted the emmercm/dat-merge-split-no-parent-fix branch September 22, 2023 02:35
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant