Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: {gameRegion} and {gameLanguage} tokens #699

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Sep 26, 2023

Fixes: #696

@emmercm emmercm self-assigned this Sep 26, 2023
@emmercm emmercm enabled auto-merge (squash) September 26, 2023 00:05
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #699 (249c7d9) into main (cd4fe62) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #699   +/-   ##
=======================================
  Coverage   93.50%   93.51%           
=======================================
  Files          82       82           
  Lines        4930     4937    +7     
  Branches     1080     1082    +2     
=======================================
+ Hits         4610     4617    +7     
  Misses        303      303           
  Partials       17       17           
Files Coverage Δ
src/modules/argumentsParser.ts 98.11% <ø> (ø)
src/modules/candidateWriter.ts 86.63% <100.00%> (ø)
src/types/dats/release.ts 86.95% <100.00%> (ø)
src/types/internationalization.ts 100.00% <ø> (ø)
src/types/outputFactory.ts 100.00% <100.00%> (ø)

@github-actions
Copy link

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/game-region-language-tokens" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm merged commit 94e503a into main Sep 26, 2023
52 checks passed
@emmercm emmercm deleted the emmercm/game-region-language-tokens branch September 26, 2023 00:21
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a {fileReleaseRegion} output path token that is inferred from the file name
1 participant