Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't memoize recursive functions #755

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Oct 11, 2023

No description provided.

@emmercm emmercm self-assigned this Oct 11, 2023
@emmercm emmercm enabled auto-merge (squash) October 11, 2023 22:54
@github-actions
Copy link

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/fix-7zip-memoize" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #755 (64d3993) into main (9106ac0) will decrease coverage by 0.06%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
- Coverage   93.65%   93.60%   -0.06%     
==========================================
  Files          83       83              
  Lines        5047     5051       +4     
  Branches     1129     1128       -1     
==========================================
+ Hits         4727     4728       +1     
- Misses        302      305       +3     
  Partials       18       18              
Files Coverage Δ
src/types/files/archives/sevenZip.ts 72.34% <66.66%> (-4.41%) ⬇️

@emmercm emmercm merged commit 2095c42 into main Oct 11, 2023
53 checks passed
@emmercm emmercm deleted the emmercm/fix-7zip-memoize branch October 11, 2023 23:11
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant