Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: limit concurrent file reads per hard drive #785

Merged
merged 13 commits into from
Oct 28, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Oct 23, 2023

Fixes: #770

@emmercm emmercm self-assigned this Oct 23, 2023
@github-actions
Copy link

github-actions bot commented Oct 23, 2023

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/drive-semaphore" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm marked this pull request as ready for review October 28, 2023 22:50
@emmercm emmercm enabled auto-merge (squash) October 28, 2023 22:50
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #785 (7fab25d) into main (58abf4f) will increase coverage by 0.14%.
The diff coverage is 83.09%.

@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
+ Coverage   93.35%   93.50%   +0.14%     
==========================================
  Files          84       85       +1     
  Lines        5135     5189      +54     
  Branches     1165     1177      +12     
==========================================
+ Hits         4794     4852      +58     
+ Misses        323      319       -4     
  Partials       18       18              
Files Coverage Δ
src/constants.ts 93.10% <100.00%> (ø)
src/modules/argumentsParser.ts 98.12% <ø> (ø)
src/modules/datScanner.ts 87.26% <100.00%> (ø)
src/modules/romHeaderProcessor.ts 100.00% <100.00%> (ø)
src/modules/scanner.ts 100.00% <100.00%> (ø)
src/modules/patchScanner.ts 94.11% <75.00%> (-0.17%) ⬇️
src/polyfill/fsPoly.ts 85.38% <94.44%> (+1.06%) ⬆️
src/driveSemaphore.ts 72.97% <72.97%> (ø)

... and 1 file with indirect coverage changes

@emmercm emmercm merged commit bdecb10 into main Oct 28, 2023
51 of 52 checks passed
@emmercm emmercm deleted the emmercm/drive-semaphore branch October 28, 2023 23:59
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very slow working across network
1 participant