Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: validate BPS & UPS patch self checksums #815

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Nov 16, 2023

No description provided.

@emmercm emmercm self-assigned this Nov 16, 2023
@emmercm emmercm enabled auto-merge (squash) November 16, 2023 05:18
Copy link

github-actions bot commented Nov 16, 2023

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/ups-bps-self-check" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5629ab6) 93.51% compared to head (b618ea5) 93.49%.

Files Patch % Lines
src/types/patches/bpsPatch.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
- Coverage   93.51%   93.49%   -0.02%     
==========================================
  Files          85       85              
  Lines        5210     5227      +17     
  Branches     1185     1187       +2     
==========================================
+ Hits         4872     4887      +15     
- Misses        320      322       +2     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit b851854 into main Nov 16, 2023
51 of 52 checks passed
@emmercm emmercm deleted the emmercm/ups-bps-self-check branch November 16, 2023 05:32
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant