Feature: add {adam} outputToken, docs and tests #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Branch testing instructionsThis pull request can be tested locally with the following command: npm exec --yes -- "github:juliadin/igir#feature-outputToken-adam" [commands..] [options]Comment generated by the Pull Request Commenter workflow. |
even though FAT32 is usually not case sensitive
TODO: sort and comment tests
added 2 commits
November 29, 2023 08:19
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 85 85
Lines 5247 5252 +5
Branches 1193 1194 +1
=======================================
+ Hits 4904 4909 +5
Misses 325 325
Partials 18 18 ☔ View full report in Codecov by Sentry. |
|
From my side, this is ready to merge, I think. All of the sorting I wanted to do is done. I have found a 'bug' though in sorting for playstation and will open a bug/try and fix it later today. |
emmercm
approved these changes
Nov 29, 2023
🔒 Inactive pull request lockThis pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Comment generated by the GitHub Lock Issues workflow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for sorting roms using the Adam OpenDingux image: https://github.com/eduardofilo/RG350_adam_image
Necessary tests have been done and sorting works with my handheld