Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ensure the fixdat dir exists before writing #873

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jan 4, 2024

No description provided.

@emmercm emmercm self-assigned this Jan 4, 2024
@emmercm emmercm enabled auto-merge (squash) January 4, 2024 01:01
Copy link

github-actions bot commented Jan 4, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/ensure-fixdat-dir" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (33213da) 93.46% compared to head (1792b0d) 93.45%.

Files Patch % Lines
src/modules/fixdatCreator.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
- Coverage   93.46%   93.45%   -0.02%     
==========================================
  Files          86       86              
  Lines        5298     5300       +2     
  Branches     1214     1215       +1     
==========================================
+ Hits         4952     4953       +1     
- Misses        328      329       +1     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 89ae8c1 into main Jan 4, 2024
51 checks passed
@emmercm emmercm deleted the emmercm/ensure-fixdat-dir branch January 4, 2024 01:15
Copy link

github-actions bot commented Feb 3, 2024

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant