270 complex numbers #289
Open
270 complex numbers #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanueleghedini
force-pushed
the
1.0.0-rc1
branch
from
c5e939f
to
1eeae0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #270
(Continuation of PR #284 targeting 1.0.0-rc1)
Added custom datatypes following the Python representation:
4+5j. It would be preferable if we could find existing adopted datatypes.The choice of "j" to denote imaginary numbers can be discussed. Chosen here to be aligned with Python. However, if we want to generalise to quatarnions, probably "i" would be a better choice, allowing them to be represented with ("i", "j", "k"), avoiding "l" which is difficult to distinguish from 1.
Open for comments. An alternative representation would be as a JSON array with two elements:
[4, 5]. There exists probably already a well-known datatype for JSON data.