Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable advanced search page caching #1408

Merged

Conversation

abelemlih
Copy link
Collaborator

@abelemlih abelemlih commented Apr 12, 2024

  • Disable caching the advanced search page
  • Override app/helpers/blacklight_advanced_search/advanced_helper_behavior.rb to initialize and use one query parser to check if a facet value is checked, refer to method def facet_value_checked?
  • Change advanced search facet views to use facet label directly instead of using #facet_display_value. The use of facet_display_value leads to a massive number of allocations when the field rendered has a lot of values.
  • Remove advanced search page caching related logic from indexing

@abelemlih abelemlih force-pushed the abel-1407-fix_advanced_search branch from c738e81 to d096da2 Compare April 16, 2024 17:28
@abelemlih abelemlih changed the base branch from main to hotfix/v1.12.1-fix_advanced_search April 16, 2024 19:43
@abelemlih abelemlih force-pushed the abel-1407-fix_advanced_search branch from b682e89 to c32f81b Compare April 16, 2024 19:47
@abelemlih abelemlih marked this pull request as ready for review April 16, 2024 19:57
@bwatson78 bwatson78 merged commit 727493f into hotfix/v1.12.1-fix_advanced_search Apr 16, 2024
1 check passed
@bwatson78 bwatson78 deleted the abel-1407-fix_advanced_search branch April 16, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants