Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export styled and css macro Flow types #1562

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

FezVrasta
Copy link
Member

@FezVrasta FezVrasta commented Oct 23, 2019

What:
I added macro.js.flow files to @emotion/styled and @emotion/css packages, so that they are properly typed and export the same types of the non-macro versions of the packages.

Why:
Right now if you import the macro versions, Flow complains because we are trying to import a file without type annotations.

How:
Added macro.js.flow files.

Checklist:

  • Documentation N/A
  • Tests N/A
  • Code complete
  • Changeset

fixes #1515

@FezVrasta FezVrasta requested a review from Andarist October 23, 2019 11:43
@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2019

🦋 Changeset is good to go

Latest commit: a4c1c57

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Andarist Andarist merged commit 11bea3a into master Oct 23, 2019
@Andarist Andarist deleted the fix/export-macros-flow-types branch October 23, 2019 11:56
@github-actions github-actions bot mentioned this pull request Oct 23, 2019
louisgv pushed a commit to louisgv/emotion that referenced this pull request Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

styled components typed as "any"
2 participants