Warn about being used as object style's key #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 97f693f We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
force-pushed
the
dev-hint/undefined-obj-key
branch
from
065b6e9 to
a4e674e
Compare
Codecov Report
|
Andarist
force-pushed
the
dev-hint/undefined-obj-key
branch
from
a4e674e to
a07a903
Compare
emmatown
reviewed
Oct 29, 2019
packages/serialize/src/index.js
Outdated
| key, | ||
| value[i] | ||
| )};` | ||
| string += `${key}:${processStyleValue(key, value[i])};` |
There was a problem hiding this comment.
Why is processStyleName not being used here?
There was a problem hiding this comment.
Oh, I was experimenting with code changes - didn't mean to actually commit this. Gonna revert this back in a moment and gonna add a test for this.
Andarist
force-pushed
the
dev-hint/undefined-obj-key
branch
from
a07a903 to
97f693f
Compare
|
@mitchellhamilton done with the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1097