-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump Prettier and Prettier accessories to 2.x #2387
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 97fa025:
|
Codecov Report
|
Excluded Markdown files because some of them had a lot of noise.
arrowParens: avoid | ||
semi: false | ||
singleQuote: true | ||
trailingComma: none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I agree with the Prettier defaults here, but for the sake of touching fewer files added the overrides to preserve this repo's old behavior. Thoughts?
arrowParens: avoid | |
semi: false | |
singleQuote: true | |
trailingComma: none | |
semi: false | |
singleQuote: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ye, keeping the output as close to what we have in the repo currently is preferable (although I also agree that we could switch defaults of those 2 later on)
We'll have to merge this into the |
@JoshuaKGoldberg I've handled the merge, it wasn't that bad after all - luckily there were no real code changes, just formatting. Next step: get this PR merged - #2360 |
What:
Bumps the
prettier
-related packages inpackage.json
to their latest versions.Why:
Newer versions of Prettier support newer TypeScript syntax things such as template type strings and type imports.
How:
yarn prettier "./*" --write
Excluded Markdown files because some of them had a lot of noise.
Checklist:
I realize it is a little weird for me to send this kind of touch-many-files PR, as someone who has yet to meaningfully contribute to Emotion. But it's going to be very useful for #2360. No worries if someone else takes it over in a new PR 😄