-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[memoize] Migrate to TypeScript #2427
[memoize] Migrate to TypeScript #2427
Conversation
🦋 Changeset detectedLatest commit: 1fe749f The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1fe749f:
|
I think I may have messed up the changeset 😞 Is a changeset necessary for each individual migration PR or will we just have a single changeset when the |
Probably best to create a changeset per individual migration PR - you deserve the attribution in the generated (based on those changesets) changelog! 😉 |
53e31a7
to
c31cc38
Compare
6bab64c
to
ad9e9b3
Compare
What:
Migrates the
memoize
package to TypeScript. This is a simple migration really. The main difference from the flow types was just needing to declare a name for the callback function's argument.Why:
Part of #2358
How:
I renamed the index.js file to
index.ts
and then uncommented the Flow types and then updated them to TypeScript.Checklist:
I think the best way to test this is by running
yarn build memoize
and then verifying that thedist/declarations/src/index.d.ts
file is correct.