[is-prop-valid] Convert to TypeScript #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 887d846 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 887d846:
|
Andarist
reviewed
Aug 14, 2021
| @@ -1,3 +1,6 @@ | |||
| /** | |||
| * This module needs to remain pure JavaScript for codegen to work on it | |||
There was a problem hiding this comment.
this makes sense 👍 making this go through something like ts-node would be overengineered, I'm OK with this being a JS file
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Converting
is-prop-validto TypeScript (mostly)Why: Part of #2358
How: Converted the
index.jstoindex.ts.props.jsI think needs to stay as regular JavaScript forcodegento work.. at least I couldn't figure out how to configure codegen to work with TypeScript. Maybe @Andarist you'll be able to figure that out if you're more familiar with that plugin.Checklist: