-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade website to latest Next.js #2571
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2b329ba:
|
This should be ready to merge apart from the manypkg issue described below.
|
This is required for next-mdx-remote v4
Superseded by #2805. |
Changes
styled-system
libraryChecklist
Minor Issues
@docsearch/react
. I have reported it to them, and it only happens in dev.Live Editors
warn - ../node_modules/@babel/standalone/babel.js Critical dependency: the request of a dependency is an expression
babel-plugin-macros
that started appearing when I did the module stubbing stuff to get@emotion/babel-plugin
to work without thefs
module.Visual Changes
I rewrote much of the website's CSS, copying from the original CSS as needed. Here is a summary of the changes.
SiteHeader
, add gray background and box-shadow. (The logo is awesome so I wanted it to be bigger)npm
innpm i @emotion/css
is now green.h1
within the body of the document. I think it is better to just useh1
for the main title for accessibility/usability/SEO/styling reasons. So I "downgraded" headings where needed.