Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make runtime label extraction opt-in #2815

Merged
merged 9 commits into from
Jun 13, 2024
Merged

Conversation

srmagura
Copy link
Contributor

@srmagura srmagura commented Jul 9, 2022

Closes #2762.

I decided to document the new global flag, since I would be frustrated if my labels suddenly disappeared and there was nothing on our docs site about it.

@srmagura srmagura requested a review from Andarist July 9, 2022 14:21
@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2022

🦋 Changeset detected

Latest commit: c3c43fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@emotion/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 9, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link

codecov bot commented Jul 9, 2022

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.48%. Comparing base (f4640f6) to head (5591561).
Report is 50 commits behind head on main.

Current head 5591561 differs from pull request most recent head c3c43fa

Please upload reports for the commit c3c43fa to get more accurate results.

Additional details and impacted files
Files Coverage Δ
packages/react/src/emotion-element.js 94.66% <50.00%> (-5.34%) ⬇️

... and 10 files with indirect coverage changes

@scttcper
Copy link

@srmagura @Andarist would love to see this get merged as we'd like to disable stack based labels during tests and this would be an easy way to do that. Changes look good. Might consider making the flag true by default until the next major version though.

@mleibman-db
Copy link

Any traction on this?

@Andarist Andarist merged commit 65a1eea into emotion-js:main Jun 13, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make runtime label extraction opt-in
4 participants