Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert @emotion/primitives-core to TypeScript #2818

Merged
merged 5 commits into from
Jul 31, 2022

Conversation

srmagura
Copy link
Contributor

Part of #2358.

@srmagura srmagura requested a review from Andarist July 10, 2022 15:47
@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2022

⚠️ No Changeset found

Latest commit: 2c00874

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 10, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2c00874:

Sandbox Source
Emotion Configuration

@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #2818 (2c00874) into ts-migration (945169b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
packages/primitives-core/src/css.ts 100.00% <100.00%> (ø)
packages/primitives-core/src/styled.ts 100.00% <100.00%> (ø)
packages/primitives-core/src/utils.ts 100.00% <100.00%> (ø)


// This is based on the StyleSheet type from @types/react-native
export interface AbstractStyleSheet {
create<T extends NamedStyles<T> | NamedStyles<any>>(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it's an interesting constraint. I can't say that I fully understand why it is written like this. I guess this will be OK or we'll just learn that it's not when converting @emotion/native and stuff 🤷‍♂️

@srmagura srmagura force-pushed the ts-primitives-core branch from 0bc1e86 to 2c00874 Compare July 31, 2022 14:59
@srmagura
Copy link
Contributor Author

Should be good now 🙂

@srmagura srmagura merged commit 8546dd0 into emotion-js:ts-migration Jul 31, 2022
@srmagura srmagura deleted the ts-primitives-core branch July 31, 2022 15:19
@github-actions github-actions bot mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants