-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert @emotion/primitives-core
to TypeScript
#2818
Convert @emotion/primitives-core
to TypeScript
#2818
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2c00874:
|
Codecov Report
|
|
||
// This is based on the StyleSheet type from @types/react-native | ||
export interface AbstractStyleSheet { | ||
create<T extends NamedStyles<T> | NamedStyles<any>>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it's an interesting constraint. I can't say that I fully understand why it is written like this. I guess this will be OK or we'll just learn that it's not when converting @emotion/native
and stuff 🤷♂️
0bc1e86
to
2c00874
Compare
Should be good now 🙂 |
Part of #2358.