Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert @emotion/cache's source code to TypeScript #3277

Merged
merged 12 commits into from
Dec 3, 2024
Merged

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Dec 2, 2024

No description provided.

@Andarist Andarist requested a review from emmatown December 2, 2024 11:31
Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 3e72e8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@emotion/cache Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

: weakMemoize(() =>
memoize(() => {
let cache = {}
return name => cache[name]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funny thing, I think this was incorrect since #1817 . It was working because we were able to store properties on this function that was returned from here. We should be returning an object though. The caller is responsible both for reading and writing to this "cache"

Copy link

codesandbox-ci bot commented Dec 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Andarist Andarist merged commit 8dc1a6d into main Dec 3, 2024
9 checks passed
@Andarist Andarist deleted the migrate-cache-to-ts branch December 3, 2024 08:37
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants