fix: file write error when file is not present (#235)

empirical-run · Dec 2, 2024 · 651cce1 · 651cce1
1 parent 1d967b8
commit 651cce1
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 14 deletions.
diff --git a/.changeset/nervous-pets-dream.md b/.changeset/nervous-pets-dream.md
@@ -0,0 +1,5 @@
+---
+"appwright": patch
+---
+
+fix: file write error when file is not present
diff --git a/src/providers/browserstack/index.ts b/src/providers/browserstack/index.ts
@@ -206,15 +206,13 @@ export class BrowserStackDeviceProvider implements DeviceProvider {
           });
           if (response.status !== 200) {
             // Retry if not 200
-            logger.error(
+            throw new Error(
               `Video not found: ${response.status} (URL: ${videoURL})`,
             );
-            return;
           }
           const reader = response.body?.getReader();
           if (!reader) {
-            logger.error("Failed to get reader from response body.");
-            return;
+            throw new Error("Failed to get reader from response body.");
           }
           const streamToFile = async () => {
             // eslint-disable-next-line no-constant-condition
@@ -240,9 +238,14 @@ export class BrowserStackDeviceProvider implements DeviceProvider {
       return new Promise((resolve, reject) => {
         // Ensure file stream is closed even in case of an error
         fileStream.on("finish", () => {
-          fs.renameSync(tempPathForWriting, pathToTestVideo);
-          logger.log(`Download finished and file closed: ${pathToTestVideo}`);
-          resolve({ path: pathToTestVideo, contentType: "video/mp4" });
+          try {
+            fs.renameSync(tempPathForWriting, pathToTestVideo);
+            logger.log(`Download finished and file closed: ${pathToTestVideo}`);
+            resolve({ path: pathToTestVideo, contentType: "video/mp4" });
+          } catch (err) {
+            logger.error(`Failed to rename file: `, err);
+            reject(err);
+          }
         });
 
         fileStream.on("error", (err) => {

diff --git a/src/providers/lambdatest/index.ts b/src/providers/lambdatest/index.ts
@@ -189,15 +189,13 @@ export class LambdaTestDeviceProvider implements DeviceProvider {
           });
           if (response.status !== 200) {
             // Retry if not 200
-            logger.error(
+            throw new Error(
               `Video not found: ${response.status} (URL: ${videoURL})`,
             );
-            return;
           }
           const reader = response.body?.getReader();
           if (!reader) {
-            logger.error("Failed to get reader from response body.");
-            return;
+            throw new Error("Failed to get reader from response body.");
           }
           const streamToFile = async () => {
             // eslint-disable-next-line no-constant-condition
@@ -223,9 +221,14 @@ export class LambdaTestDeviceProvider implements DeviceProvider {
       return new Promise((resolve, reject) => {
         // Ensure file stream is closed even in case of an error
         fileStream.on("finish", () => {
-          fs.renameSync(tempPathForWriting, pathToTestVideo);
-          logger.log(`Download finished and file closed: ${pathToTestVideo}`);
-          resolve({ path: pathToTestVideo, contentType: "video/mp4" });
+          try {
+            fs.renameSync(tempPathForWriting, pathToTestVideo);
+            logger.log(`Download finished and file closed: ${pathToTestVideo}`);
+            resolve({ path: pathToTestVideo, contentType: "video/mp4" });
+          } catch (err) {
+            logger.error(`Failed to rename file: `, err);
+            reject(err);
+          }
         });
 
         fileStream.on("error", (err) => {