fix page title tot updating correctly when only the model changes

empress · Jan 10, 2021 · cdd3e78 · cdd3e78
1 parent f8f58a6
commit cdd3e78
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 3 deletions.
diff --git a/addon/services/head-data.js b/addon/services/head-data.js
@@ -18,10 +18,13 @@ export default class HeadDataService extends HeadData {
   }
 
   @computed('routeName')
-  get currentRouteMeta() {
-    let currentController = getOwner(this).lookup(`controller:${this.routeName}`)
+  get currentController() {
+    return getOwner(this).lookup(`controller:${this.routeName}`)
+  }
 
-    return currentController.model.post ?? currentController.model;
+  @computed('currentController.model.post')
+  get currentRouteMeta() {
+    return this.currentController.model.post ?? this.currentController.model;
   }
 
   @computed('currentRouteMeta.name', 'routeName')

diff --git a/tests/acceptance/meta-test.js b/tests/acceptance/meta-test.js
@@ -48,6 +48,32 @@ module('Acceptance | meta test', function(hooks) {
       .hasAttribute('content', 'article');
     assert.dom('head meta[property="og:image"]', document)
       .hasAttribute('content', 'https://empress-blog.netlify.com/images/welcome.jpg');
+
+    await visit('/managing-users');
+
+    assert.dom('head meta[property="og:title"]', document)
+      .hasAttribute('content', 'Managing Ghost users');
+    assert.dom('head meta[name="description"]', document)
+      .hasAttribute('content', `empress-blog does not, and will never have the concept of user roles! This is because it is entirely a static system. You can assign authors to posts and generate new ones using...`);
+    assert.dom('head meta[name="twitter:label1"]', document)
+      .hasAttribute('content', 'Written by');
+    assert.dom('head meta[name="twitter:data1"]', document)
+      .hasAttribute('content', 'Chris Manson');
+    assert.dom('head meta[name="twitter:label2"]', document)
+      .hasAttribute('content', 'Filed under');
+    assert.dom('head meta[name="twitter:data2"]', document)
+      .hasAttribute('content', 'Getting Started, Recent posts');
+    assert.dom('head link[rel="canonical"]', document)
+      .hasAttribute('href', 'https://empress-blog.netlify.com/managing-users/');
+    // I'm not testing the value of conent here to avoid timezone variations
+    assert.dom('head meta[property="article:published_time"]', document)
+      .hasAttribute('content');
+    assert.dom('head meta[property="article:tag"]', document)
+      .hasAttribute('content', 'Getting Started');
+    assert.dom('head meta[property="og:type"]', document)
+      .hasAttribute('content', 'article');
+    assert.dom('head meta[property="og:image"]', document)
+      .hasAttribute('content', 'https://empress-blog.netlify.com/images/team.jpg');
   })
 
   test('page meta', async function(assert) {