Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Page Blueprint #104

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Add Page Blueprint #104

merged 1 commit into from
Mar 3, 2021

Conversation

elwayman02
Copy link
Contributor

@elwayman02 elwayman02 commented Jan 23, 2021

Should work exactly the same as a post, except the file is generated into the page directory.

This blueprint will need to be updated to add meta once #103 is merged.

Fixes #85

Should work exactly the same as a post, except the file is generated into the `page` directory.
@elwayman02
Copy link
Contributor Author

@mansona can you take a look at this one?

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@elwayman02
Copy link
Contributor Author

@mansona if you want to go ahead and merge this one, I'll update #103 to add the meta field to this new blueprint. Alternatively, if you want to review and merge #103 first since it's larger, it's trivial for me to update this PR after instead.

@mansona
Copy link
Member

mansona commented Mar 3, 2021

@elwayman02 sorry for the delay, I was a bit concerned about not having the test run so that's why I got distracted converting over to github actions 😂

I'm going to force merge this one since it's not covered by tests anyway 👍

@mansona mansona merged commit 287cc6c into empress:master Mar 3, 2021
@elwayman02 elwayman02 deleted the page-blueprint branch March 3, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Page
2 participants