Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actual local image embed when mentioned in guide content #111

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

elwayman02
Copy link
Contributor

Neither the demo app nor the blueprint utilized an actual local image embed despite talking specifically about it in the guides and purporting to show an example. This updates the example to use an image from the public/ folder rather than an externally-hosted image. There is already an example of an externally-hosted image in one of the other content files, so I left that one as an example. It seemed appropriate to change this one since it's where the guides specifically talk about using images in the public/ directory in empress-blog

Closes #109

Neither the demo app nor the blueprint utilized an actual local image embed despite talking specifically about it in the guides and purporting to show an example. This updates the example to use an image from the public/ folder rather than an externally-hosted image. There is already an example of an externally-hosted image in one of the other content files, so I left that one as an example. It seemed appropriate to change this one since it's where the guides specifically talk about using images in the public/ directory in empress-blog
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea seems reasonable 🎉

@mansona mansona merged commit d42343d into empress:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't embed local images in markdown
2 participants