Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Ember < 3.16 and update with ember-cli-update #147

Merged
merged 6 commits into from
Dec 6, 2021

Conversation

mansona
Copy link
Member

@mansona mansona commented Nov 23, 2021

No description provided.

@mansona mansona force-pushed the update-ember branch 3 times, most recently from d29d0b7 to 3399d97 Compare November 23, 2021 18:02
Copy link
Contributor

@elwayman02 elwayman02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great other than the open question re: prettier exemptions.

@mansona
Copy link
Member Author

mansona commented Dec 6, 2021

and it looks like this is as green as we're going to get for CI for now, the issue with ember-release-no-deprecations is actually in ember data and they haven't released ember-data@4 yet so I can't check if adding latest to the ember-data version will fix it.

But this is still great news 🎉 finally empress-blog supports Ember 4.0 😍

@mansona mansona merged commit f9ceae9 into master Dec 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-ember branch December 6, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants